-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/#review101361
-----------------------------------------------------------



3rdparty/libprocess/src/tests/digest_tests.cpp (line 130)
<https://reviews.apache.org/r/38814/#comment158729>

    You might have to take care of the else case also.



3rdparty/libprocess/src/tests/digest_tests.cpp (line 158)
<https://reviews.apache.org/r/38814/#comment158728>

    You will have to guard the call to "digest" with 
DigestTypeTraits<Digest::ANY>::is_implemented.


- Jojy Varghese


On Oct. 2, 2015, 6:29 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38814/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 6:29 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> add test cases for sha512 digest verifier
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38814/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu 14.04)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to