----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38337/#review101456 -----------------------------------------------------------
src/launcher/fetcher.cpp (line 70) <https://reviews.apache.org/r/38337/#comment158848> Why not use two separate names and avoid the variable update? Suggestion: pathWithoutExtension. src/launcher/fetcher.cpp (line 71) <https://reviews.apache.org/r/38337/#comment158849> There are hundreds of occurences of "filename" and only 3 of "fileName". So my guess is that we should use "filename" here against your and my better judgement :-) src/tests/fetcher_tests.cpp (line 573) <https://reviews.apache.org/r/38337/#comment158850> s/extract_file/extractedFile - Bernd Mathiske On Oct. 5, 2015, 12:39 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38337/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 12:39 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, and Timothy Chen. > > > Bugs: MESOS-3407 > https://issues.apache.org/jira/browse/MESOS-3407 > > > Repository: mesos > > > Description > ------- > > Extract gz file in fetcher. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff > src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 > > Diff: https://reviews.apache.org/r/38337/diff/ > > > Testing > ------- > > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="FetcherTest.ExtractGzipFile" --verbose > > > Thanks, > > haosdent huang > >
