-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38932/#review101459
-----------------------------------------------------------

Ship it!



src/health-check/main.cpp (line 208)
<https://reviews.apache.org/r/38932/#comment158855>

    Following the JIRA discussion, this change seems to be in line with 
Gabriels sentence "It's fine that the health check fails potentially forever if 
the command is malformed.", right?
    Otherwise I would suggest to keep `promise.fail` here.



src/health-check/main.cpp (line 215)
<https://reviews.apache.org/r/38932/#comment158856>

    Not your's, but please change that to `Future<Option<int>>`.



src/health-check/main.cpp (line 231)
<https://reviews.apache.org/r/38932/#comment158854>

    Is there a reason why this is `kill` and not `os::killtree` here?


- Jan Schlicht


On Oct. 3, 2015, 3:26 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38932/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 3:26 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3479
>     https://issues.apache.org/jira/browse/MESOS-3479
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Kill health check external command process and continue check after timeout.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 
> 
> Diff: https://reviews.apache.org/r/38932/diff/
> 
> 
> Testing
> -------
> 
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.CheckCommandTimeout" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to