> On Oct. 4, 2015, 7:30 a.m., Guangya Liu wrote:
> > src/slave/http.cpp, line 316
> > <https://reviews.apache.org/r/38899/diff/1/?file=1087826#file1087826line316>
> >
> >     I think that the blank line is not needed.

It's always considered good practice to have a newline after a multiline 
continuation statement.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101439
-----------------------------------------------------------


On Sept. 30, 2015, 5:02 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 5:02 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Bugs: MESOS-2296
>     https://issues.apache.org/jira/browse/MESOS-2296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Trivial change to call the `executorMessage(...)` function that already 
> existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
> 
> Diff: https://reviews.apache.org/r/38899/diff/
> 
> 
> Testing
> -------
> 
> make check. Would add tests later after the MESOS-3480 review chain gets 
> committed.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to