----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review101663 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 41 - 43) <https://reviews.apache.org/r/39019/#comment159120> Is this necessary? (Do the calls to `FindNextFile`, `FindClose`, or `FindFirstFile` require C or something?) 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 51 - 53) <https://reviews.apache.org/r/39019/#comment159118> I'm not really sure how necessary this comment is. (And the two identical notes below.) Presumably, we already know this because: 1) This is Stout. 2) This file is in the `internal` folder. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 87) <https://reviews.apache.org/r/39019/#comment159122> Seems like this will give a negative array access if you set `path = "";`. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 165 - 166) <https://reviews.apache.org/r/39019/#comment159123> Opening curly brace should be moved up. - Joseph Wu On Oct. 5, 2015, 3:12 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39019/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 3:12 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Added dirent compat code for non-Unix systems. > > > Diffs > ----- > > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 50e35f43d87c69a83a9e7d039d1881404ea8be38 > > Diff: https://reviews.apache.org/r/39019/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
