> On Oct. 6, 2015, 5:09 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 37 > > <https://reviews.apache.org/r/39005/diff/1/?file=1091859#file1091859line37> > > > > When strerror_r() returns EINVAL, you return an empty string?
Also, you should force the XSI-compliant one rather than the GNU one which returns a pointer. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review101665 ----------------------------------------------------------- On Oct. 6, 2015, 3:07 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 3:07 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > This adds a thread-safe wrapper around strerror_r which has semantics similar > to strerror. We plan to use this at call sites currently relying on strerror. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp > 12ba1ca861114e60f8276c0ee91c543abcfc2519 > 3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp > 9e7605c53e6636e7fea32e4f69fbaff9100a979f > > Diff: https://reviews.apache.org/r/39005/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
