-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38873/#review101709
-----------------------------------------------------------

Ship it!


Will get this committed shortly.


src/internal/evolve.hpp (lines 100 - 101)
<https://reviews.apache.org/r/38873/#comment159171>

    Why did you wrap?
    
    ```
    >>> len('v1::executor::Event evolve(const 
StatusUpdateAcknowledgementMessage& message);')
    78
    ```



src/internal/evolve.cpp (lines 304 - 305)
<https://reviews.apache.org/r/38873/#comment159172>

    Why did you wrap?
    
    ```
    >>> len('  kill->mutable_task_id()->CopyFrom(evolve(message.task_id()));')
    63
    ```



src/internal/evolve.cpp (lines 317 - 318)
<https://reviews.apache.org/r/38873/#comment159173>

    Ditto about wrapping here and elsewhere


- Ben Mahler


On Oct. 5, 2015, 11:09 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38873/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 11:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
>     https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change implements helper functions for evolving old style Executor 
> messages in `src/messages/messages.proto` to V1 Executor Events defined in 
> `include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
>   src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 
> 
> Diff: https://reviews.apache.org/r/38873/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to