-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37996/#review101707
-----------------------------------------------------------

Ship it!


Like most other reviewers, I must confess that my first reaction when seeing 
this tree application where mixed and triggered doubts if we really needed to 
introduce it. However, I found Alexander's given points very convincing and I 
also see no alternatives by now.


3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (lines 197 
- 198)
<https://reviews.apache.org/r/37996/#comment159166>

    The empty brackets should go up according to our style.
    ```
    InheritanceTree<T>::InheritanceTree() : root_(std::make_shared<Node>()) {}
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (lines 202 
- 203)
<https://reviews.apache.org/r/37996/#comment159168>

    See above.



3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp (line 65)
<https://reviews.apache.org/r/37996/#comment159199>

    s/trailered/trailed/



3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp (line 101)
<https://reviews.apache.org/r/37996/#comment159200>

    s/of /of a/
    s/introduce/introduced/ 
    s/return/returns/


- Till Toenshoff


On Oct. 6, 2015, 8:24 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37996/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 8:24 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3231
>     https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the `InheritanceTree` class which allows to create a tree where 
> nodes can be tag with some property. This property is then inherited by 
> children nodes.
> 
> Two behaviors are implemented, overriding, i.e. Adding a property to the 
> child node of another node with a property already will result in the 
> ancestor property being lost. The second behavior, accumulating, takes a 
> function and accumulates
> properties of all ancestors.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 94292f8a46ec31bbaf6e52f48109322bbe123f70 
>   3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37996/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to