----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101787 -----------------------------------------------------------
Patch looks great! Reviews applied: [39088] All tests passed. - Mesos ReviewBot On Oct. 7, 2015, 3:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39088/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 3:24 p.m.) > > > Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3517 > https://issues.apache.org/jira/browse/MESOS-3517 > > > Repository: mesos > > > Description > ------- > > The test environment does not enforce that we run with a defined locale, > so instead enforce it for our particular use case (here: potentially > localized error messages from shell). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e > > Diff: https://reviews.apache.org/r/39088/diff/ > > > Testing > ------- > > With German locale installed: > > % LANG=de_DE.UTF-8 make check > > > Thanks, > > Benjamin Bannier > >
