-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review101801
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 39)
<https://reviews.apache.org/r/39097/#comment159292>

    Should be `endif (APPLE)`
    
    ```
    CMake Warning (dev) at 3rdparty/libprocess/3rdparty/CMakeLists.txt:295 
(include):
      A logical block opening on the line
    
        
/Users/josephwu/mesos/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake:36
 (if)
    
      closes on the line
    
        
/Users/josephwu/mesos/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake:39
 (endif)
    
      with mis-matching arguments.
    ```


- Joseph Wu


On Oct. 7, 2015, 10:53 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39097/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 10:53 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 
> 
> Diff: https://reviews.apache.org/r/39097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to