> On Oct. 7, 2015, 10:06 p.m., Anand Mazumdar wrote:
> > src/log/replica.cpp, line 378
> > <https://reviews.apache.org/r/39104/diff/1/?file=1092535#file1092535line378>
> >
> >     Nit : This line is > 80 chars. Can we wrap this ?

That line is 74 characters long, by my count :)


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39104/#review101822
-----------------------------------------------------------


On Oct. 7, 2015, 9:41 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39104/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 9:41 p.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3417
>     https://issues.apache.org/jira/browse/MESOS-3417
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3417.
> 
> 
> Diffs
> -----
> 
>   src/log/replica.cpp 2bfcc3eccb0dc019dd0dfe6027a3560c6fdbcff0 
> 
> Diff: https://reviews.apache.org/r/39104/diff/
> 
> 
> Testing
> -------
> 
> "make check", ran mesos-master by hand. Example output:
> 
> I1007 21:33:05.434449 27039 replica.cpp:478] Replica received implicit 
> promise request from (4)@10.0.2.15:5050 with proposal 5
> [...]
> I1007 21:33:05.444855 27042 replica.cpp:512] Replica received write request 
> for position 17 from (5)@10.0.2.15:5050
> [...]
> I1007 21:33:05.446867 27039 replica.cpp:660] Replica received learned notice 
> for position 17 from @0.0.0.0:0
> [...]
> I1007 21:33:05.451514 27042 replica.cpp:512] Replica received write request 
> for position 18 from (6)@10.0.2.15:5050
> [...]
> I1007 21:33:05.452555 27042 replica.cpp:660] Replica received learned notice 
> for position 18 from @0.0.0.0:0
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to