----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review101844 -----------------------------------------------------------
Let's include a test that breaks with `bytes` but works with `string` in this patch! - Michael Park On Oct. 7, 2015, 7:06 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39098/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 7:06 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > ------- > > When decoding the JSON credential file into the Credential protobuf object, > the 'secret' which is in 'bytes' is mapped into base64 string automatically > by protobuf from JSON. This creates an unintended behavior, forcing users to > encode in base64 their secret when wanting to pass a JSON file to the > --credentials flag. > > > Diffs > ----- > > include/mesos/mesos.proto 4a16be1 > > Diff: https://reviews.apache.org/r/39098/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
