----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/ -----------------------------------------------------------
(Updated Oct. 8, 2015, 9:51 p.m.) Review request for mesos and Timothy Chen. Changes ------- reverted back emplace_back. There is a ton of information of why emplace_back is preferred([1], [2]) but we might need a general agreement on the adopting the usage. 1] http://www.gahcep.com/cpp-internals-stl-vector-part-2/ 2] http://stackoverflow.com/questions/26860749/efficiency-of-c11-push-back-with-stdmove-versus-emplace-back-for-already Repository: mesos Description ------- Store: minor style changes Diffs (updated) ----- src/slave/containerizer/provisioner/docker/store.cpp cbb67686d45513f0395a0cf1bc5c43cb4935adae Diff: https://reviews.apache.org/r/39141/diff/ Testing ------- make check. Thanks, Jojy Varghese
