----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review102283 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 741) <https://reviews.apache.org/r/39211/#comment159873> Nit: s/picojson/PicoJson/ (For consistency with other comments about PicoJson) 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 754) <https://reviews.apache.org/r/39211/#comment159878> Nit: We don't put periods in error messages. - Joseph Wu On Oct. 10, 2015, 8:05 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39211/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2015, 8:05 p.m.) > > > Review request for mesos, Adam B and Joseph Wu. > > > Bugs: MESOS-3698 > https://issues.apache.org/jira/browse/MESOS-3698 > > > Repository: mesos > > > Description > ------- > > Check for trailing characters in JSON::parse(). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 0870300c2d372722b4850155cb2a8e848b986ed5 > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp > b95667f4c1a1c170016da024a5e4af02ccaa064e > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 131d39b87e571f16c774a133eb3148e98d8b9dd4 > > Diff: https://reviews.apache.org/r/39211/diff/ > > > Testing > ------- > > Added tests to make sure that JSON::parse() is successfully returning errors > when passed invalid JSON objects. Ran `make check`. > > > Thanks, > > Greg Mann > >
