-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/#review102290
-----------------------------------------------------------



3rdparty/libprocess/src/help.cpp (lines 41 - 75)
<https://reviews.apache.org/r/39037/#comment159884>

    To make things consistent, how about we take every argument as a const 
reference here and do the newline append directly to 'help', as you've done for 
description:
    
    ```
    string HELP(
        const string& tldr,
        const Option<std::string>& description,
        const Option<string>& references)
    {
      // Construct the help string.
      string help =
        "### TL;DR; ###\n" +
        tldr;
    
      if (!strings::endsWith(help, "\n")) {
        help += "\n";
      }
    
      if (description.isSome()) {
        help +=
          "\n"
          "### DESCRIPTION ###\n" +
          description.get();
    
        if (!strings::endsWith(help, "\n")) {
          help += "\n";
        }
      }
    
      if (references.isSome()) {
        help += "\n";
        help += references.get();
      }
    
      return help;
    }
    ```


- Ben Mahler


On Oct. 8, 2015, 6:59 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39037/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
>     https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow description empty in help information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 
> e7dc670648e8abd2fef7be79835f0b71e3e91258 
>   3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 
> 
> Diff: https://reviews.apache.org/r/39037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to