Oh man, me too. :) On Mon, Oct 12, 2015 at 11:50 AM, Benjamin Mahler <[email protected] > wrote:
> Apologies, I've committed the fix for cmake. Looking forward to getting it > set up in jenkins to catch these! > > On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang <[email protected]> > wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/37024/ >> >> On October 10th, 2015, 10:17 a.m. UTC, *Alex Clemmer* wrote: >> >> src/Makefile.am >> <https://reviews.apache.org/r/37024/diff/11/?file=1092775#file1092775line554> >> (Diff >> revision 11) >> >> 554 >> >> version/version.cpp \ >> >> Hmm, I know this is submitted, but can we go back and add this also to the >> CMakeLists.txt in src/? >> >> Sorry, my fault to forgot update CMake. I open >> https://reviews.apache.org/r/39212/, could you help review it? >> >> >> - haosdent >> >> On October 8th, 2015, 7:01 a.m. UTC, haosdent huang wrote: >> Review request for mesos and Ben Mahler. >> By haosdent huang. >> >> *Updated Oct. 8, 2015, 7:01 a.m.* >> *Bugs: * MESOS-1841 <https://issues.apache.org/jira/browse/MESOS-1841> >> *Repository: * mesos >> Description >> >> Add an endpoint exposes Apache Mesos build informations and version >> information. >> >> Testing >> >> Manual test result: >> >> $ curl http://localhost:5050/version 2>/dev/null|jq . >> { >> "version": "0.26.0", >> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3", >> "git_branch": "refs/heads/MESOS-1841", >> "build_user": "haosdent", >> "build_time": 1444185166, >> "build_date": "2015-10-07 10:32:46" >> } >> >> Diffs >> >> - src/Makefile.am (e69892736b0edc8c264eaccd52a04d44d01f53ba) >> - src/exec/exec.cpp (7b51baaa8c08d248918974a3a22b6217e388bcb1) >> - src/local/main.cpp (18b2f0187637cd425d55c220f73faac5a1218f0f) >> - src/master/main.cpp (bafc605d6c20bd264b932e44ee80373a3f692734) >> - src/sched/sched.cpp (571e00d303009a940f17c8ed4582749a718e846d) >> - src/slave/main.cpp (854ade491c2bad0bb041cd94968215f9fd8fa4ae) >> - src/version/version.hpp (PRE-CREATION) >> - src/version/version.cpp (PRE-CREATION) >> >> View Diff <https://reviews.apache.org/r/37024/diff/> >> > > -- Alex Theory is the first term in the Taylor series of practice. -- Thomas M Cover (1992)
