----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39204/#review102319 -----------------------------------------------------------
Ship it! Looks good. (Checked that logical content of `read.hpp` is identical to `posix/read.hpp`.) 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp (lines 136 - 138) <https://reviews.apache.org/r/39204/#comment159925> Nit: 2 newlines too many - Joseph Wu On Oct. 10, 2015, 1:12 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39204/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2015, 1:12 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > ------- > > Windows: Added support for `stout/os/read.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > ffacce164980157ea225a4e64e33b8bf8ec38ab7 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d5698a5b44fd6083ac3119d6825d31f46efb2f38 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > 09d63329f16f13d408742f9fc8f596d76c4d70c9 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 50e35f43d87c69a83a9e7d039d1881404ea8be38 > > Diff: https://reviews.apache.org/r/39204/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
