-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39209/#review102327
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (lines 78 - 79)
<https://reviews.apache.org/r/39209/#comment159936>

    Can you add a comment here?  (Pretty much what you said in the description).


- Joseph Wu


On Oct. 10, 2015, 4:46 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39209/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 4:46 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `Windows.h` head includes a header that defines the UUID struct for
> the DCE RPC API. This is dumped into the global namespace, just like our
> UUID implementation found in `stout/uuid.hpp`.
> 
> Since this causes a compilation error on Windows, we simply move our
> UUID into `stout::`. We further add a `using stout::UUID;` in the file
> so that we don't have to change every callsite in the Mesos codebase
> that uses it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> bc167f1fa9e64f89138f131e726e7733c66da29c 
> 
> Diff: https://reviews.apache.org/r/39209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to