----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/#review102337 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp (line 47) <https://reviews.apache.org/r/39213/#comment159943> Maybe add a `// __linux__` here, even though it wasn't there originally. - Joseph Wu On Oct. 11, 2015, 11:16 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39213/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2015, 11:16 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > ------- > > Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`. > > (NOTE: this does not close MESOS-3632, but does contribute to its resolution.) > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 5141c1369af60afd6cd5c70c6295d575ea960a83 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/bootid.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39213/diff/ > > > Testing > ------- > > Built CMake solution and ran `make check` (or equivalent) on Windows 10, > Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on > Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
