----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/#review102402 -----------------------------------------------------------
LGTM. 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines 62 - 64) <https://reviews.apache.org/r/39076/#comment160034> micro-nit: shall the values be aligned here and below (in the else branch)? - Artem Harutyunyan On Oct. 12, 2015, 10:51 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39076/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 10:51 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Added ability of Windows builds to include protobuf headers. > > > Diffs > ----- > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > ee1c74d31e28136bf289f4100d79a8ce568cd3af > > Diff: https://reviews.apache.org/r/39076/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
