----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39092/#review102405 -----------------------------------------------------------
LGTM. - Artem Harutyunyan On Oct. 7, 2015, 9 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39092/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 9 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3597 > https://issues.apache.org/jira/browse/MESOS-3597 > > > Repository: mesos > > > Description > ------- > > Right now running the Mesos tests from the default tests target will (1) > aggregate all our tests into a semi-useless report that hides all the > errors, and (2) strip all our colors when you do pass the verbosity flag > to get rid of the "report" structure. > > This commit will prepare us to run the tests with with color, without > this default reporting structure. We do this by moving the tests target > to a `CACHE STRING` which can be referenced by the tests. > > > Diffs > ----- > > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > ea6db09e1a1aa01450aee93814e07f09feae7ac9 > 3rdparty/libprocess/src/tests/CMakeLists.txt > a14b5b8fe22d3e75bef3c716ae7865ddaf132927 > > Diff: https://reviews.apache.org/r/39092/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >