> On Oct. 13, 2015, 11:01 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180, 39181, > > 39201, 39182, 39202, 39203, 39204, 39207, 39208, 39209, 39210, 39213, > > 39217, 39218, 39219, 39220] > > > > Failed command: ./support/apply-review.sh -n -r 39220 > > > > Error: > > 2015-10-13 11:01:08 URL:https://reviews.apache.org/r/39220/diff/raw/ > > [4689/4689] -> "39220.patch" [1] > > error: patch failed: CMakeLists.txt:89 > > error: CMakeLists.txt: patch does not apply > > error: patch failed: src/CMakeLists.txt:223 > > error: src/CMakeLists.txt: patch does not apply > > Failed to apply patch
39220 is a review that used to apply and no longer does. Looks like it's time to update the whole chain! - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/#review102430 ----------------------------------------------------------- On Oct. 13, 2015, 9:10 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39265/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 9:10 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Move `os::environment` to its own file. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 5141c1369af60afd6cd5c70c6295d575ea960a83 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39265/diff/ > > > Testing > ------- > > `make check` on Ubuntu 15, OS X 10.10, and running the `check` project on > Windows 10. > > > Thanks, > > Alex Clemmer > >