> On Oct. 12, 2015, 2:13 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 41-42 > > <https://reviews.apache.org/r/39208/diff/1/?file=1094551#file1094551line41> > > > > Do you want to `#include <stout/os/close.hpp>` too? > > Alex Clemmer wrote: > Interesting, you must be seeing good reasons to do this that I haven't > seen yet. Is it just to make the header self-contained? Is that what best > practice is here? (I'm pretty much 100% a C++ noob.)
Yup. If we (for some inexplicable reason) change open.hpp to *not* include close.hpp, we wouldn't want this file to change if that happens. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/#review102325 ----------------------------------------------------------- On Oct. 13, 2015, 11:31 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39208/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 11:31 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3634 > https://issues.apache.org/jira/browse/MESOS-3634 > > > Repository: mesos > > > Description > ------- > > Windows: Add windows support to `stout/protobuf.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 2285ce9eaba668d5215c108849055fe92163da4d > > Diff: https://reviews.apache.org/r/39208/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
