-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39180/#review102557
-----------------------------------------------------------


LGTM.


3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp (lines 50 - 52)
<https://reviews.apache.org/r/39180/#comment160264>

    It'd be great to clarify this comment (discussed offline with Alex).


- Artem Harutyunyan


On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39180/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3693
>     https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `stout/os/open.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
> 43f261fd7a60b534f642f826ebf6ab18d72180c2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp 
> 023993d859e3a101ca387c1a514cd75de0d2beb1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/open.hpp 
> 14fa11765c222cb4e80f5e45360d0f05facb578e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39180/diff/
> 
> 
> Testing
> -------
> 
> Ran both stout_tests from VS.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to