-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38978/#review102629
-----------------------------------------------------------

Ship it!


This looks good!
Tried it out locally.


support/hooks/post-rewrite (line 14)
<https://reviews.apache.org/r/38978/#comment160365>

    How come you chose not to follow the whitespace check in the existing 
pre-commit hook?



support/hooks/post-rewrite (lines 15 - 19)
<https://reviews.apache.org/r/38978/#comment160364>

    Can you add a comment explaining what the `@~..@` is doing here?


- Joris Van Remoortere


On Oct. 4, 2015, 8:08 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38978/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2015, 8:08 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2953
>     https://issues.apache.org/jira/browse/MESOS-2953
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add post-rewrite hook.
> 
> 
> Diffs
> -----
> 
>   bootstrap 779b33cdcb88b2417769bb046a17b47cd6042f2d 
>   support/hooks/post-rewrite PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38978/diff/
> 
> 
> Testing
> -------
> 
> test manually
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to