> On Oct. 14, 2015, 11:24 p.m., James Peach wrote: > > Automake detects sed, so I think that you should do something like this: > > > > SED_I = $(SED) -i.orig > > > > foo: bar > > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@ > > Neil Conway wrote: > I suppose there's value in using $(SED) instead of "sed". Using > $(AM_V_GEN) when running some commands but not others (e.g., protoc) seems > inconsistent to me, though. > > I'm inclined to replace "sed" with $(SED) and leave it at that (since it > would be nice to unbreak the build); we can consider further cleanup > separately.
That's fair enough. Just for fun, here's a diff with pretty PROTOC output http://fpaste.org/279307/48670631/ :) - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102718 ----------------------------------------------------------- On Oct. 14, 2015, 11:41 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39323/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 11:41 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-3734 > https://issues.apache.org/jira/browse/MESOS-3734 > > > Repository: mesos > > > Description > ------- > > 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on > OSX. Apparently there is not a portable way to instruct sed not to make a > backup > file; hence, we now create a backup file and then immediately delete it. > > > Diffs > ----- > > src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d > > Diff: https://reviews.apache.org/r/39323/diff/ > > > Testing > ------- > > Successfully built on OSX. > > > Thanks, > > Neil Conway > >
