----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102876 -----------------------------------------------------------
src/slave/containerizer/fetcher.cpp (line 794) <https://reviews.apache.org/r/39338/#comment160688> What's this string parameter that you're ignoring? If it's the Failure message, I'd think you'd want to log that too. Should this lambda return a Future<Nothing> too? Otherwise, how will it run the following onAny cleanup below? - Adam B On Oct. 15, 2015, 6:11 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39338/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 6:11 a.m.) > > > Review request for mesos, Benjamin Bannier, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3743 > https://issues.apache.org/jira/browse/MESOS-3743 > > > Repository: mesos > > > Description > ------- > > Added an onFailed() clause to the inspection of the fetcher subprocess run. > This clause copies the fetcher log from <task sandbox>/stderr and appends it > to the agent log. > > This is to facilitate debugging spurious fetch failures in production or CI. > > Similar, but not the same: https://reviews.apache.org/r/37813/ (see > MESOS-3743 for an explanation). > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 2b2298c329ed5fb5863cb0fed1491e478c3e5d5a > > Diff: https://reviews.apache.org/r/39338/diff/ > > > Testing > ------- > > Ran make check. As expected no change in behavior. > When I modified the fetcher to fail, > I observed the expected extra output. > > > Thanks, > > Bernd Mathiske > >
