----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review102935 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/metadata_manager.cpp (line 80) <https://reviews.apache.org/r/39331/#comment160767> Could you add comments on what the purpose of ImagePool is? src/tests/containerizer/provisioner_docker_tests.cpp (line 920) <https://reviews.apache.org/r/39331/#comment160769> How does this make sure that the same future was returned ? - Jojy Varghese On Oct. 14, 2015, 10:54 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39331/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 10:54 p.m.) > > > Review request for mesos, Anand Mazumdar, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-3736 > https://issues.apache.org/jira/browse/MESOS-3736 > > > Repository: mesos > > > Description > ------- > > Support docker local store pull image simultaneously > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/metadata_manager.cpp > 2b2de5245bccbd01a856b214ac6525278d794537 > src/slave/containerizer/provisioner/docker/store.cpp > 637c97c0973bda492826803a962c99635647692d > src/tests/containerizer/provisioner_docker_tests.cpp > 9c3c45a81be6398722a37911788e347a4e91cce8 > > Diff: https://reviews.apache.org/r/39331/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
