> On Oct. 16, 2015, 6:21 p.m., Ben Mahler wrote: > > Thanks Neil! It looks like we have overlap between this and the effective > > code review doc here: > > http://mesos.apache.org/documentation/latest/effective-code-reviewing/ > > > > Should we just link to this from the submitting a patch doc? Anything you > > think should be added / changed in the code review doc?
Ah, I hadn't seen that -- I think overlap isn't the end of the world, and a lot of new contributors won't read the code-reviewing page. How about both adding some text to submitting-a-patch and also including a link to the code-reviewing page? - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102955 ----------------------------------------------------------- On Oct. 16, 2015, 4:41 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 4:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Added docs for how developers should split their work into Git commits. > > > Diffs > ----- > > docs/submitting-a-patch.md cbd99fe3fd162703165933336700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
