-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39404/#review102962
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 16, 2015, 6:25 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39404/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Artem Harutyunyan.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Not sure how this hook worked before because it wasn't exiting when there are 
> style or split errors.
> 
> 
> Diffs
> -----
> 
>   support/hooks/pre-commit 09ce57816b4aa953fea6bd9574223626edb23699 
> 
> Diff: https://reviews.apache.org/r/39404/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> ?  mesos git:(master) ./support/apply-review.sh 38051
> 2015-10-16 11:18:52 URL:https://reviews.apache.org/r/38051/diff/raw/ 
> [4737/4737] -> "38051.patch" [1]
> Successfully applied: Only update the task status when its old status is not 
> terminal.
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Review: https://reviews.apache.org/r/38051
> Checking 2 files using filter 
> --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> src/tests/status_update_manager_tests.cpp:927:  Lines should be <= 80 
> characters long  [whitespace/line_length] [2]
> Total errors found: 1
> Failed to commit patch
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to