> On Oct. 16, 2015, 8:15 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, line 20
> > <https://reviews.apache.org/r/39380/diff/2/?file=1100132#file1100132line20>
> >
> >     Is this addition related?
> >     
> >     (It's good to have nevertheless.)

Yep, there's a direct reference in this file to `Bytes`, which will cause 
compile errors when we pull the inclusion of `os.hpp` elsewhere.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39380/#review102978
-----------------------------------------------------------


On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39380/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 7:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `stout/flags/flags.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> b91318cfd5748b3387bb6b32b910f327853274dd 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
> e34ed78386130a1e757be1b1f1a2dbf794b7cd37 
> 
> Diff: https://reviews.apache.org/r/39380/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to