> On Oct. 19, 2015, 9:34 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/README.md, line 81
> > <https://reviews.apache.org/r/39455/diff/1/?file=1101223#file1101223line81>
> >
> >     All on one line?

Initializer list typically go on the next line. Hence, dropping.


> On Oct. 19, 2015, 9:34 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/README.md, line 106
> > <https://reviews.apache.org/r/39455/diff/1/?file=1101223#file1101223line106>
> >
> >     Probably should return a value, although not required by C++.

It's implicit for `main()`. Dropping.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39455/#review103160
-----------------------------------------------------------


On Oct. 19, 2015, 9:17 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39455/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 9:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39455/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/hatred/76a7619ba7b892dd0542
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to