> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote:
> > src/tests/module.hpp, lines 76-77
> > <https://reviews.apache.org/r/38627/diff/1/?file=1088893#file1088893line76>
> >
> >     same comment here - it would be great to have fully-documented, 
> > properly-formatted javadoc here, also explaining what could go into 
> > `parameters` how will this affect creating the module, etc.
> >     
> >     while this may all appear obvious to you, it may not be so to external 
> > developers using this code to launch/test modules.
> >     
> >     thanks!

Hey Marco. You're wrong saying that external developers will have to use any of 
this functions, they are use only internally. There are also a lot of examples 
on how to write modules, if you look in the 
[src/examples](https://github.com/apache/mesos/tree/bb8409882c1e1b5c7eea2a4528f5d3d33dc639b1/src/examples)
 directory, all the files with suffix `_module.cpp` show how to write modules. 
More documentation on the matter can be found at 
[modules.md](https://github.com/apache/mesos/blob/bb8409882c1e1b5c7eea2a4528f5d3d33dc639b1/docs/modules.md).

I however see your point on the need of documentation for the `ModuleManager` 
and I created the JIRA MESOS-3767 which addresses that. I don't add it in this 
patch, because this patch creates overloads of existing methods and uses the 
same documentation of the previous ones. In order to keep the changes localize 
to what concerns this patch, we agree with my shepherd to add the relevant 
documentation in a future patch.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review102245
-----------------------------------------------------------


On Oct. 20, 2015, 12:18 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 12:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
>     https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -----
> 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to