-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/#review103273
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/socket.hpp (lines 30 - 32)
<https://reviews.apache.org/r/39377/#comment161264>

    I think elsewhere we didn't leave a new line here?



3rdparty/libprocess/src/poll_socket.cpp (lines 17 - 18)
<https://reviews.apache.org/r/39377/#comment161265>

    we usually include `stout` after `process` right?


- Joris Van Remoortere


On Oct. 19, 2015, 11:26 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39377/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
>     https://issues.apache.org/jira/browse/MESOS-3628
>     https://issues.apache.org/jira/browse/MESOS-3649
>     https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Add Windows support to `process/socket.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp 
> 4b2597f617fc4072144c9666a378d4ffad53a592 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39377/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to