----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/#review103272 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 83) <https://reviews.apache.org/r/39375/#comment161263> Can this be a constexpr? - Joris Van Remoortere On Oct. 19, 2015, 11:25 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39375/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 11:25 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > POSIX has a bunch of flags like `SHUT_SD` which let you do things like > specify (e.g.) how a socket shuts down. Windows has equivalents for many > of these flags as well, but they have different names. > > So that we can avoid changing any of the socket code, we alias the flags > we know we need with their POSIX names. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 4a0761f4bdd6a881429cb25d0a5f6e445da405cb > > Diff: https://reviews.apache.org/r/39375/diff/ > > > Testing > ------- > > CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 > on Windows 10. > > Autotools `make check` on Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
