-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39379/#review103280
-----------------------------------------------------------

Ship it!


- Joris Van Remoortere


On Oct. 19, 2015, 11:27 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39379/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we remove the line that includes `stout/os.hpp` from
> `stout/flags/flags.hpp`, it will break `slave/launcher.cpp`. Our
> solution is to directly include the parts of `os.hpp` that are relevant
> to the launcher.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/posix.hpp 
> ee9d275e7fe5fc22c1bab86dd0a558cc8ab9044e 
>   src/slave/containerizer/launcher.cpp 
> 6649d35ec593d264e8508a8195f2470f05888c0a 
> 
> Diff: https://reviews.apache.org/r/39379/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to