> On Oct. 20, 2015, 7:13 p.m., Joris Van Remoortere wrote: > > It might be worth splitting out the "logical" changes from the textual. > > As in the dispatch and test position variable. > > Otherwise we should update the commit message as that is not all that is > > happening in this patch.
I revised the commit message. Happy to split into more commits if you'd prefer. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/#review103293 ----------------------------------------------------------- On Oct. 19, 2015, 11:25 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39463/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 11:25 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and > Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Fixed typos in log messages and comments in replicated log code. > > > Diffs > ----- > > src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 > src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a > src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 > src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 > src/state/log.cpp a75a605a4b0edb8863a3378e2133df7d6eb1cc3d > src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e > src/tests/slave_tests.cpp 10a4fa7eaa8e868ccc6d60ac220d66a4f0a523b4 > > Diff: https://reviews.apache.org/r/39463/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
