-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103312
-----------------------------------------------------------

Ship it!


I guess you want to retain apply-reviews.sh for backward compatibility; 
however, it can be entirely retired by making apply-reviews.py executable 
(`chmod a+x`) and adding a shebang at the top:
```
#!/usr/bin/env python
```


support/apply-review.sh (line 3)
<https://reviews.apache.org/r/39420/#comment161291>

    I really dislike this style of conditional running stuff in bash (it also 
violates Google's style, but that's another story :) )
    ```
    if [[ ! -f "support/apply-reviews.py" ]]; then
        echo "..."
        exit 1
    fi
    
    python ./support/apply-reviews.py "$@"
    ```



support/apply-reviews.py (lines 267 - 272)
<https://reviews.apache.org/r/39420/#comment161292>

    did you introduce leading tabs?
    (it may very well be a RB artifact, difficult to tell)


- Marco Massenzio


On Oct. 20, 2015, 7:45 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 7:45 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to