-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103320
-----------------------------------------------------------



src/slave/slave.cpp (line 1938)
<https://reviews.apache.org/r/39497/#comment161303>

    Should this executor ID be quoted as well?



src/slave/slave.cpp (line 1941)
<https://reviews.apache.org/r/39497/#comment161302>

    Should this executor ID be quoted as well?



src/slave/slave.cpp (line 1955)
<https://reviews.apache.org/r/39497/#comment161304>

    This one too?



src/slave/slave.cpp (line 1988)
<https://reviews.apache.org/r/39497/#comment161305>

    Should this executor ID be quoted as well? Also, could you remove the 
extraneous space at the beginning of this error message?



src/slave/slave.cpp (lines 2121 - 2122)
<https://reviews.apache.org/r/39497/#comment161306>

    Two single quotes before `executorId`, none after.



src/slave/slave.cpp (lines 2136 - 2137)
<https://reviews.apache.org/r/39497/#comment161307>

    Two single quotes before executorId, none after.



src/slave/slave.cpp (line 3460)
<https://reviews.apache.org/r/39497/#comment161308>

    Could you also remove the period at the end of this error message?



src/slave/slave.cpp (line 3506)
<https://reviews.apache.org/r/39497/#comment161309>

    Could you also remove the extraneous space at the beginning of this error 
message?


- Greg Mann


On Oct. 20, 2015, 10:04 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 10:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
>     https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> -------
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to