----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103360 -----------------------------------------------------------
src/master/quota_handler.cpp (lines 29 - 31) <https://reviews.apache.org/r/39285/#comment161373> adjust the order of the two imports src/master/quota_handler.cpp (line 57) <https://reviews.apache.org/r/39285/#comment161374> Can we put the "request" info to the log message for better debugability? src/master/quota_handler.cpp (line 111) <https://reviews.apache.org/r/39285/#comment161379> Can we put those two roles in the Error msg? src/master/quota_handler.cpp (line 126) <https://reviews.apache.org/r/39285/#comment161378> Can we use return Error("Quota Request for unknown role '" + role + "'"); src/master/quota_handler.cpp (line 182) <https://reviews.apache.org/r/39285/#comment161381> Remove this new line - Guangya Liu On 十月 19, 2015, 8:11 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > ----------------------------------------------------------- > > (Updated 十月 19, 2015, 8:11 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > Added Quota Request Validation. > > > Diffs > ----- > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
