> On Oct. 21, 2015, 6:11 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 1416 > > <https://reviews.apache.org/r/38000/diff/8/?file=1101631#file1101631line1416> > > > > s/are ignored/is ignored/ > > s/tests/test/ or s/this/these/
I fixed the second, but it is _"are ignored"_ since the noun here is not header but _"the contents"_ which happen to belong to the header. Or the header's contents. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review103355 ----------------------------------------------------------- On Oct. 20, 2015, 12:09 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38000/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 12:09 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3233 > https://issues.apache.org/jira/browse/MESOS-3233 > > > Repository: mesos > > > Description > ------- > > Adds functions which allows libprocess users to add handlers which require > authentication as well as functions to install and remove authenticators. > > Includes tests. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 8b086f296c80a43be2edaf496a04dadf0c64251a > 3rdparty/libprocess/src/process.cpp > 954d31424bc8f8ecfa78b80513c480f2514ec271 > 3rdparty/libprocess/src/tests/http_tests.cpp > d13d3888abbf3db552df4a9f83e54667e598ded9 > > Diff: https://reviews.apache.org/r/38000/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
