----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39518/#review103739 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/registry_client.cpp (line 615) <https://reviews.apache.org/r/39518/#comment161819> I find it surprising that this would need to be handled here since I would have expected a proper `write` to deal with that correctly. Are you trying to work-around a bug elsewhere? src/slave/containerizer/provisioner/docker/registry_client.cpp (line 633) <https://reviews.apache.org/r/39518/#comment161817> This seems to be happen in `write(int fd, void* data, size_t size)` already anyway. src/slave/containerizer/provisioner/docker/registry_client.cpp (line 641) <https://reviews.apache.org/r/39518/#comment161818> Wouldn't this potentially cause data loss if the called `write` function cannot dump everything in the `fd`? - Benjamin Bannier On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39518/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 6:13 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3773 > https://issues.apache.org/jira/browse/MESOS-3773 > > > Repository: mesos > > > Description > ------- > > See MESOS-3773. > > Change: > io::write(fd, string) has been having issues with junk being written to the > file. Using io::write(fd, void*, size_t) does not have this issue. > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/registry_client.cpp > 24aa95c5800ff4dfb37465b71421b014b5dd5998 > > Diff: https://reviews.apache.org/r/39518/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Jojy Varghese > >
