This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 23, 2015, 7:21 p.m.)

Review request for mesos, Benjamin Hindman and Kapil Arya.


- Removed JSON model() implementation for NetworkInfo in favor of inlined usage 
of JSON::Protobuf().
- Clarified wording in the NetworkInfo banner comment.
- Updated Mesos versions in inline deprecation comments.

Bugs: MESOS-3788

Repository: mesos


In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

Diffs (updated)

  docs/networking-for-mesos-managed-containers.md 33568a8 
  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.hpp 0cc98a8 
  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp 1e49013 
  src/examples/test_hook_module.cpp 43d6cb9 
  src/slave/slave.cpp e9f2d1b 
  src/tests/common/http_tests.cpp c2e7704 
  src/tests/hook_tests.cpp 5a5d019 

Diff: https://reviews.apache.org/r/39531/diff/


make && make check


Connor Doyle

Reply via email to