-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review103951
-----------------------------------------------------------

Ship it!


Looks like a legit regexp improvement to me.

- Adam B


On Oct. 22, 2015, 4:03 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 4:03 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The previous regexp was:
> 
>     /\((.*)(\.md)\)/
> 
> Given text like:
> 
>     Text (comment): [link](foo.md)
> 
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c 
> 
> Diff: https://reviews.apache.org/r/39385/diff/
> 
> 
> Testing
> -------
> 
> Tested using support/site-docker -- a few places where the old regexp screwed 
> up were corrected, otherwise no changes observed.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to