-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review104019
-----------------------------------------------------------

Ship it!


Thanks for taking this on Greg!
Greg will follow up with some patches to make the style in this document 
consistent. We've kept it locally consistent for now.


docs/configuration.md (lines 1659 - 1660)
<https://reviews.apache.org/r/39494/#comment162210>

    `the libevent development package is required`?



docs/configuration.md (line 1660)
<https://reviews.apache.org/r/39494/#comment162209>

    `version 2+`



docs/configuration.md (line 1670)
<https://reviews.apache.org/r/39494/#comment162211>

    `--enable-libevent is currently required`?



docs/configuration.md (line 1888)
<https://reviews.apache.org/r/39494/#comment162217>

    It seems like there are 2 forms of this flag / message:
    `--with-libevent[=DIR]` and ``--with-libevent=[=DIR]``
    
    It seems like there are 2 forms of this message:
    ```
    excludes building and using the bundled XXX package in lieu of an installed 
version at a location prefixed by the given path
    ```
    and what you have.
    Feel free to make them totally consistent with a new review.
    
    Here and below.


- Joris Van Remoortere


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to