-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review104061
-----------------------------------------------------------

Ship it!


This looks good! You missed launcher and linux_launcher (those are mesos 
containerizer specific). For the rest, it looks good. I'll commit this first 
and you can follow up with a patch to move launcher and linux_launcher.

- Jie Yu


On Oct. 20, 2015, 10 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 10 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
>     https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   src/slave/containerizer/provisioner/docker/paths.cpp 
> 5733fb7137b1ecb8a904cc5354425c60c9e065f5 
>   src/slave/containerizer/provisioner/docker/puller.hpp 
> 105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
>   src/slave/containerizer/provisioner/docker/puller.cpp 
> cb05324689ffa26ce830b513e2d71b55517da3cb 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp  
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
>   src/slave/containerizer/provisioner/docker/spec.hpp 
> 199db540e44581a411ce63082b917821d29360a8 
>   src/slave/containerizer/provisioner/docker/spec.cpp 
> 5d6893dc6875eb67e3724f184c5ad171f94d88fa 
>   src/slave/containerizer/provisioner/docker/store.hpp 
> b5e6c87d38bea531c1b504915a84625fc9777e0d 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> 50340131d10222ac06cf21e87ad46943f171d1f6 
>   src/slave/containerizer/provisioner/docker/token_manager.hpp  
>   src/slave/containerizer/provisioner/docker/token_manager.cpp 
> 18b29c3d0ddf25fd3f4713c5de10aeec3b381df0 
>   src/slave/containerizer/provisioner/paths.hpp  
>   src/slave/containerizer/provisioner/paths.cpp 
> 8d0f7d3cd6af132112f22d8709bc401745c5f43a 
>   src/slave/containerizer/provisioner/provisioner.hpp  
>   src/slave/containerizer/provisioner/provisioner.cpp 
> 30a85a52ee5986c6e1652edfd08ae881280b23ab 
>   src/slave/containerizer/provisioner/store.hpp  
>   src/slave/containerizer/provisioner/store.cpp 
> a8bc30264c58aa46a1eb8b6b4466114d9ed1acdc 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 1e332e0d36ac2812456514aa030f995b3a07dca1 
>   src/tests/containerizer/isolator_tests.cpp 
> 237f3f27722b01ff92d0dcbaba7910613542a1a7 
>   src/tests/containerizer/port_mapping_tests.cpp 
> feca2043503436ac9abac6017ae9059b3fcbed21 
>   src/tests/containerizer/provisioner.hpp 
> 54aab5f279c66d57f9054ef8d9b37bd58f727bb8 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 3da759a5e6dd305c7c5455d26b5136065ed64c32 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> b72edc6696955409e101e036182092dff4c64c10 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 01d3025f59d4a2714a856fe0f3a57192be023990 
>   src/tests/disk_quota_tests.cpp 1ed1342a10a4d59b84ef13a3d66eef95150c4e53 
> 
> Diff: https://reviews.apache.org/r/39360/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu14.04 + clang-3.6)
> 
> Important Note: 
> Currently some patches pending to be committed rely on the old directory, 
> which means that it will result in corresponding changes(fix conflicts during 
> rebasing) in these patches on reviewboard if this post was merged. Please 
> make a note below if you currently have patches working on MesosContainerizer 
> and want this patch to be discarded and redo in the future.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to