-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39703/#review104240
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39702, 39703]

All tests passed.

- Mesos ReviewBot


On Oct. 27, 2015, 9:54 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39703/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3688
>     https://issues.apache.org/jira/browse/MESOS-3688
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The container-id is mesos-specific and so it's not quite clear what good 
> could it do. However, for Docker containers, one can use the "docker 
> container id" for various things such as "docker ps". This particular patch 
> doesn't expose docker container ids yet.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e 
>   src/common/http.cpp f56d8a178e1f61d91adfeaad32b47718adbc4379 
>   src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 
>   src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 
> 
> Diff: https://reviews.apache.org/r/39703/diff/
> 
> 
> Testing
> -------
> 
> make check with updated MasterTest.TaskStatusContainerStatus test.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to