----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review104052 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (lines 78 - 81) <https://reviews.apache.org/r/39539/#comment162254> order? 3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp (line 16) <https://reviews.apache.org/r/39539/#comment162266> `<string>` `<stout/error.hpp>` 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 232) <https://reviews.apache.org/r/39539/#comment162593> We can add a comment here about the flag we're using to try and emulate the POSIX behavior. - Joris Van Remoortere On Oct. 27, 2015, 6:32 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39539/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 6:32 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3441 > https://issues.apache.org/jira/browse/MESOS-3441 > > > Repository: mesos > > > Description > ------- > > Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ba2836a72ceee948cb43364e80ada9f132f33d04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 7f70c9ea7d57634b5bfd40523ba37561ec92a09a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 7a8819541506f57f70a9b577dc97a76fc26ebaa8 > > Diff: https://reviews.apache.org/r/39539/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
