> On Oct. 30, 2015, 2:03 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, line 179
> > <https://reviews.apache.org/r/39771/diff/1/?file=1112445#file1112445line179>
> >
> >     I suggest that we use 'path' instead.
> >     
> >     ABORT(string("Failed to os::execvpe '") + path + "' in childMain: " +

It will format like "Failed to os::execvpe(.. path ..)", which not only looks 
pretty, but makes whitespace obvious :)


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39771/#review104507
-----------------------------------------------------------


On Oct. 29, 2015, 9 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39771/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3608
>     https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Show the failing path when execvpe(2) fails.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 459825c188d56d25f6e2832e5a170d806e257d6b 
> 
> Diff: https://reviews.apache.org/r/39771/diff/
> 
> 
> Testing
> -------
> 
> make check and manual testing.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to