-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39837/#review104660
-----------------------------------------------------------



src/slave/containerizer/docker.cpp 
<https://reviews.apache.org/r/39837/#comment162913>

    We intentionally exclude os enviornments as you can see here for a reason.
    
    There are a lot of environment variables that are default to the OS, that 
will break when docker containers run and we need to not include them unless 
it's specifically specified by the user with executor environement variables or 
taskinfo.
    
    The fix should be carefully picking the ones we need only.


- Timothy Chen


On Nov. 1, 2015, 9:38 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39837/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Passing os environment variables when start docker executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 5e5e0f93123b7f0bda6c8afeb4df271e796e4637 
> 
> Diff: https://reviews.apache.org/r/39837/diff/
> 
> 
> Testing
> -------
> 
> manually test.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to